Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-5610): unskip uri invalid port (zero) with hostname/IP literal tests on Node 20+ #4096

Merged
merged 1 commit into from Apr 25, 2024
Merged

test(NODE-5610): unskip uri invalid port (zero) with hostname/IP literal tests on Node 20+ #4096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 0 additions & 18 deletions test/unit/connection_string.spec.test.ts
View file
Open in desktop
@@ -1,5 +1,3 @@
import { satisfies } from 'semver';

import { loadSpecTests } from '../spec';
import { executeUriValidationTest } from '../tools/uri_spec_runner';

Expand All @@ -11,22 +9,6 @@ const skipTests = [
describe('Connection String spec tests', function () {
const suites = loadSpecTests('connection-string');

beforeEach(function () {
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const test = this.currentTest!;

const skippedTests = [
'Invalid port (zero) with IP literal',
'Invalid port (zero) with hostname'
];
test.skipReason =
satisfies(process.version, '>=20.0.0') && skippedTests.includes(test.title)
? 'TODO(NODE-5666): fix failing unit tests on Node20+'
: undefined;

if (test.skipReason) this.skip();
});

for (const suite of suites) {
describe(suite.name, function () {
for (const test of suite.tests) {
Expand Down