Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NODE-6090): Implement CSOT logic for server selection and connection checkout #4095

Open
wants to merge 67 commits into
base: main
Choose a base branch
from
Open

refactor(NODE-6090): Implement CSOT logic for server selection and connection checkout #4095

wants to merge 67 commits into from
+574 −176

Commits on Apr 26, 2024

  1. Install timeout throughout operation layer

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ab21b5b View commit details
    Browse the repository at this point in the history

  2. update with timeout

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    2338dff View commit details
    Browse the repository at this point in the history

  3. start prose test impl

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    9615138 View commit details
    Browse the repository at this point in the history

  4. add timeout to find.execute

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0eb1986 View commit details
    Browse the repository at this point in the history

  5. start implementing prose tests

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    69f1087 View commit details
    Browse the repository at this point in the history

  6. don't construct Timeout when not needed

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ff2ec44 View commit details
    Browse the repository at this point in the history

  7. ensure that timeoutMS is passed down correctly

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a3e552a View commit details
    Browse the repository at this point in the history

  8. start working on unit tests

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a9c96ac View commit details
    Browse the repository at this point in the history

  9. continue prose test implementation

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    21b2fcd View commit details
    Browse the repository at this point in the history

  10. revert spec test changes

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    892800d View commit details
    Browse the repository at this point in the history

  11. revert spec test changes

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6f62c9f View commit details
    Browse the repository at this point in the history

  12. revert spec test changes

    @W-A-James
    W-A-James committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b878c6c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. support timeout on run_command

    @W-A-James
    W-A-James committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c5fae5c View commit details
    Browse the repository at this point in the history

  2. continue prose test implementation

    @W-A-James
    W-A-James committed May 1, 2024
    Configuration menu
    Copy the full SHA
    124f2d7 View commit details
    Browse the repository at this point in the history

  3. prose test changes

    @W-A-James
    W-A-James committed May 1, 2024
    Configuration menu
    Copy the full SHA
    cd6a27e View commit details
    Browse the repository at this point in the history

  4. WIP - server selection changes

    @W-A-James
    W-A-James committed May 1, 2024
    Configuration menu
    Copy the full SHA
    b63b63f View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. revert unneeded connection changes

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9f4e884 View commit details
    Browse the repository at this point in the history

  2. add serverSelectionTimeout to run_command

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6fc1198 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into NODE-6090

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c18b7f0 View commit details
    Browse the repository at this point in the history

  4. use correct timeout

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9c40f94 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'NODE-6090' of github.com:mongodb/node-mongodb-native into 

    NODE-6090
    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a958ad8 View commit details
    Browse the repository at this point in the history

  6. reorder operations

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    a75d9df View commit details
    Browse the repository at this point in the history

  7. formatting

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    875ea67 View commit details
    Browse the repository at this point in the history

  8. skip some CSOT tests that cannot be made to pass here

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3839330 View commit details
    Browse the repository at this point in the history

  9. Improve timeout messages

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c738691 View commit details
    Browse the repository at this point in the history

  10. silence eslint test issues

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c4ae2fb View commit details
    Browse the repository at this point in the history

  11. bump timeout values

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    bf5a37a View commit details
    Browse the repository at this point in the history

  12. misc changes

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e2f9125 View commit details
    Browse the repository at this point in the history

  13. rename timeout

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    472fa9e View commit details
    Browse the repository at this point in the history

  14. make getter internal

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    43e69bd View commit details
    Browse the repository at this point in the history

  15. rename timeout

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    fb96314 View commit details
    Browse the repository at this point in the history

  16. remove unneeded change for this PR

    @W-A-James
    W-A-James committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ad55e9c View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. clear server selection timeout after checkout and remove command exec… 

    …ution timeout
    @W-A-James
    W-A-James committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6c7adf1 View commit details
    Browse the repository at this point in the history

  2. move Timeout.min to independent helper function

    @W-A-James
    W-A-James committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f586736 View commit details
    Browse the repository at this point in the history

  3. move Timeout.min to independent helper function

    @W-A-James
    W-A-James committed May 6, 2024
    Configuration menu
    Copy the full SHA
    021a94d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'main' into NODE-6090

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a61a9d0 View commit details
    Browse the repository at this point in the history

  2. update timeout propagation

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    30e564c View commit details
    Browse the repository at this point in the history

  3. clean up

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    02509a1 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7c73c58 View commit details
    Browse the repository at this point in the history

  5. test cleanup

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b92162b View commit details
    Browse the repository at this point in the history

  6. clean up

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4625af4 View commit details
    Browse the repository at this point in the history

  7. simplify calculation

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7d7f005 View commit details
    Browse the repository at this point in the history

  8. cleanup

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ecdd66d View commit details
    Browse the repository at this point in the history

  9. clarify branching timeout behaviour

    @W-A-James
    W-A-James committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9307a80 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into NODE-6090

    @aditi-khare-mongoDB
    aditi-khare-mongoDB committed May 8, 2024
    Configuration menu
    Copy the full SHA
    78ccbd8 View commit details
    Browse the repository at this point in the history

  2. operationTimeout -> timeout

    @W-A-James
    W-A-James committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c4d26c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'NODE-6090' of github.com:mongodb/node-mongodb-native into 

    NODE-6090
    @W-A-James
    W-A-James committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3590e5e View commit details
    Browse the repository at this point in the history

  4. ensure timeouts are properly cleared

    @W-A-James
    W-A-James committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f7cc3a5 View commit details
    Browse the repository at this point in the history

  5. don't race if given infinite timeout

    @W-A-James
    W-A-James committed May 8, 2024
    Configuration menu
    Copy the full SHA
    a1c7601 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. default clearTimeout to false

    @W-A-James
    W-A-James committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2ed34ac View commit details
    Browse the repository at this point in the history

  2. remove clearTimeout variable

    @W-A-James
    W-A-James committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7111909 View commit details
    Browse the repository at this point in the history

  3. conditionally clear timeout on early return

    @W-A-James
    W-A-James committed May 9, 2024
    Configuration menu
    Copy the full SHA
    86a7eeb View commit details
    Browse the repository at this point in the history

  4. fix unit tests

    @W-A-James
    W-A-James committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2a816e3 View commit details
    Browse the repository at this point in the history

  5. bump test timeout value

    @W-A-James
    W-A-James committed May 9, 2024
    Configuration menu
    Copy the full SHA
    62bb3ca View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. replace test with sinon fake timer test

    @W-A-James
    W-A-James committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cdce963 View commit details
    Browse the repository at this point in the history

  2. Update src/sdam/topology.ts 

    Co-authored-by: Neal Beeken <neal.beeken@mongodb.com>
    @W-A-James @nbbeeken
    W-A-James and nbbeeken committed May 10, 2024
    Configuration menu
    Copy the full SHA
    5c91311 View commit details
    Browse the repository at this point in the history

  3. clean up logic

    @W-A-James
    W-A-James committed May 10, 2024
    Configuration menu
    Copy the full SHA
    72c22b9 View commit details
    Browse the repository at this point in the history

  4. Update test to assert on current behaviour

    @W-A-James
    W-A-James committed May 10, 2024
    Configuration menu
    Copy the full SHA
    68f1eec View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into NODE-6090

    @W-A-James
    W-A-James committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e88191a View commit details
    Browse the repository at this point in the history

  2. fix autoconnect

    @W-A-James
    W-A-James committed May 23, 2024
    Configuration menu
    Copy the full SHA
    daf0d5a View commit details
    Browse the repository at this point in the history

  3. add test

    @W-A-James
    W-A-James committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1d9ac3e View commit details
    Browse the repository at this point in the history

  4. remove .only

    @W-A-James
    W-A-James committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e468b54 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. fix test

    @W-A-James
    W-A-James committed May 24, 2024
    Configuration menu
    Copy the full SHA
    fd6c751 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into NODE-6090

    @W-A-James
    W-A-James committed May 24, 2024
    Configuration menu
    Copy the full SHA
    bab1667 View commit details
    Browse the repository at this point in the history

  3. ensure test only runs when failcommand is available

    @W-A-James
    W-A-James committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4d126eb View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. do not run on 4.2

    @W-A-James
    W-A-James committed May 28, 2024
    Configuration menu
    Copy the full SHA
    92564d8 View commit details
    Browse the repository at this point in the history

  2. fix csot test?

    @W-A-James
    W-A-James committed May 28, 2024
    Configuration menu
    Copy the full SHA
    09a8b17 View commit details
    Browse the repository at this point in the history