refactor: cursor to use fetchBatch function when current batch is empty #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nbbeeken
force-pushed
the
refactor-cursor-nextBatch
branch
from
ef2886d
to
f39ebac
Compare
nbbeeken
force-pushed
the
refactor-cursor-nextBatch
branch
from
f39ebac
to
ff12d3d
Compare
nbbeeken
commented
May 1, 2024
Comment on lines
+526
to
+530
| if ( | ||
| options?.error == null || | ||
| options?.error?.name === 'MongoExpiredSessionError' || | ||
| options?.force | ||
| ) { |
There was a problem hiding this comment.
Without this change, endSession is sensitive to the exact order of endSession calls that were made by our cursor before this refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
nextinto cursor and rename to fetchBatchIs there new documentation needed for these changes?
No
What is the motivation for this change?
The
nextfloating function owned too many details of the implementation of each cursor API, tryNext and next now do a small amount more lifting and we have a fetchBatch method that is focused on obtaining the next batch either with the init command or with a getMore.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript