Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor test filters to typescript #4054

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: refactor test filters to typescript #4054

wants to merge 2 commits into from
+194 −165

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • import filters individually and at the top-level
  • refactor to TS and async
  • Cache FLE version
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • TS has better DX
  • remove dynamic importing for debuggability

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nbbeeken