feat(NODE-5639): keep executing context on queued commands #3871
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
…m:david-luna/node-mongodb-native into feat-command-callback-async-resource-bind
david-luna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation for https://jira.mongodb.org/browse/NODE-5639
Make use of AsyncResource.bind API to bind the current execution context of
WaitQueueMembercallback.The change proposed will make callbacks to have the same context they where created. Useful if the consumer of the package is using AsyncLocalStorage to keep state.
One use case is APM agents. They make use of these APIs to keep context between callbacks and async calls.
What is changing?
Bind the current execution context to
WaitQueueMembercallback property.Is there new documentation needed for these changes?
No
What is the motivation for this change?
Get span hierarchy right when
mongodbdriver is instrumented by an APM agent like Opentelemetry, Elastic, DataDog...Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript