test(NODE-4157): SDAM unit test typescript and improvements #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dariakp
added
the
Primary Review
dariakp
requested changes
Mar 28, 2022
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
dariakp
requested changes
Mar 28, 2022
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
dariakp
added
Team Review
nbbeeken
changed the title
nbbeeken
force-pushed
the
test/sdam-monitoring-spec-runner
branch
from
7d0edea
to
73d3fa6
Compare
nbbeeken
force-pushed
the
test/sdam-monitoring-spec-runner
branch
from
8c18e0d
to
7943e96
Compare
dariakp
requested changes
Apr 7, 2022
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
test/unit/assorted/server_discovery_and_monitoring.spec.test.ts
Outdated
Show resolved
Hide resolved
dariakp
previously approved these changes
Apr 8, 2022
nbbeeken
force-pushed
the
test/sdam-monitoring-spec-runner
branch
from
5888091
to
f62ab04
Compare
dariakp
approved these changes
Apr 8, 2022
durran
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This is a breakout of the changes from #3174
Link to commit that shows diff: 88e5473
Brings in partial spec sync, description update in:
secondary_ignore_ok_0.json(mongodb/specifications@5bd06a8)What is the motivation for this change?
During debugging the new tests these fixups were natural improvements, using chai property assertions, typescript, easier tracking of the current phase to see the change our SDAM machine will perform to the topology.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>