Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3510): omit incorrect | void in declaration of Promise overload of rename() #2922

Merged
merged 1 commit into from Aug 2, 2021
Merged

fix(NODE-3510): omit incorrect | void in declaration of Promise overload of rename() #2922

merged 1 commit into from Aug 2, 2021

Commits on Jul 30, 2021

  1. Omit incorrect void in rename()'s Promise overload 

    One of the TS overloaded declarations for `rename()` had a `| void` which AFAIK is incorrect. If a method returns a `Promise`, it should never be typed `| void`.
    @justingrant
    justingrant committed Jul 30, 2021
    Copy the full SHA
    1444aa5 View commit details
    Browse the repository at this point in the history