Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for azure and GCP CSFLE, fix aws boto3 error #2738

Merged
merged 6 commits into from Feb 19, 2021
Merged

test: add tests for azure and GCP CSFLE, fix aws boto3 error #2738

merged 6 commits into from Feb 19, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Feb 12, 2021 •
edited

Ports #2662 and #2720 for 4.0

NODE-2825
NODE-3056

@emadum
chore(ci): fix aws auth boto3 error
17b2040
@emadum
Merge remote-tracking branch 'origin/4.0' into NODE-3056/4.0/fix-aws-…
8ae3505 
…auth-test
@emadum
test: add tests for azure and GCP CSFLE (#2662)
07b5efc 
This adds new tests, and modifies the test runner to account for the recent
addition of Azure and GCP CSFLE support in the CSLFE specification.

NODE-2825
@emadum
add mongodb-extjson dev dependency
f1b1b9a
@emadum emadum changed the title Node 3056/4.0/fix aws auth test test: add tests for azure and GCP CSFLE, fix aws boto3 error Feb 12, 2021
@emadum emadum marked this pull request as ready for review February 13, 2021 00:13
nbbeeken
nbbeeken requested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing LGTM, just some CI notes

test/functional/client_side_encryption/prose.test.js Outdated Show resolved Hide resolved
.evergreen/run-tests.sh Outdated Show resolved Hide resolved
@emadum emadum requested a review from nbbeeken February 18, 2021 17:06
nbbeeken
nbbeeken approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit 85695c4 into 4.0 Feb 19, 2021
@emadum emadum deleted the NODE-3056/4.0/fix-aws-auth-test branch February 19, 2021 16:38
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
test: add tests for azure and GCP CSFLE, fix aws boto3 error (#2738)
25487b5 
This adds new tests, and modifies the test runner to account for the recent
addition of Azure and GCP CSFLE support in the CSLFE specification.
Also fixes a CI error resulting from an old boto3 dependency.

NODE-2825
NODE-3056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@emadum @durran @nbbeeken