Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): enable tls testing on windows #2722

Merged
merged 1 commit into from Jan 29, 2021
Merged

chore(ci): enable tls testing on windows #2722

merged 1 commit into from Jan 29, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jan 28, 2021

Port of #2718, the bug was already fixed so this PR only includes CI updates and the new test.

NODE-2977

@emadum emadum marked this pull request as ready for review January 29, 2021 00:18
durran
durran approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emadum emadum merged commit 5175359 into 4.0 Jan 29, 2021
@emadum emadum deleted the NODE-2977/4.0/tls-windows branch January 29, 2021 15:33
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
chore(ci): enable tls testing on windows (#2722)
d727ced 
NODE-2977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@emadum @durran @nbbeeken