New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): xunit integration [3.5] #2641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to have this on all the branches! tyty!
lib/operations/command_v2.js
Outdated
function commandSupportsCollation(command) { | ||
if (command.listCollections) return false; | ||
return true; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sets a bit of a dangerous precedent, can we move this to the command construction of the listCollections
operation? Ideally we would not ever depend on inspecting keys of command documents, hopefully we've designed the driver in such a way that we can make these determinations at the point of command construction, rather than at the wire protocol level.
test/functional/readconcern.test.js
Outdated
if (test.commandName === 'geoSearch') { | ||
metadata.requires.mongodb += ' <=4.4'; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a data-driven test, shouldn't the instructions for building the tests should be in the specs above rather than special cased here? Maybe something like serverVersion: '<=4.4'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Backports of #2596 and #2612 for
3.5
Note: also fixes a failing test on the latest server to get CI passing, related to setting collation on
listCollections
.It seems we set collation a bit too aggressively and rely on the server ignoring it where it's not supported. However, the latest server version is returning an error: