Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move kerberos client setup from prepare to auth #2608

Merged
merged 2 commits into from Nov 6, 2020

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Nov 3, 2020

Description

This PR fixes a bug in Kerberos authentication by moving the Kerberos
client initialization from the AuthProvider.prepare override into a
local makeKerberosClient function.

NODE-2859

What changed?

Are there any files to ignore?

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mod a naming nitpick

lib/core/auth/gssapi.js Outdated Show resolved Hide resolved
@mbroadst mbroadst changed the title fix: move client setup from prepare to auth fix: move kerberos client setup from prepare to auth Nov 5, 2020
@mbroadst mbroadst merged commit 033b6e7 into 3.6 Nov 6, 2020
@mbroadst mbroadst deleted the NODE-2859/kerberos-client-fix branch November 6, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants