Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change socket timeout default to 0 [PORT] #2572

Merged
merged 8 commits into from Nov 6, 2020
Merged

fix: Change socket timeout default to 0 [PORT] #2572

merged 8 commits into from Nov 6, 2020

Commits on Nov 5, 2020

  1. fix: 🔥 Change socket timeout default to 0 

    Socket timeout by default is infinity.

NODE-2835
    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    9b3da78 View commit details
    Browse the repository at this point in the history

  2. test: ✨ Add test to ensure default socketTimeout is 0

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    98f46e3 View commit details
    Browse the repository at this point in the history

  3. fix: 🔥 fix tests expecting 6min timeout

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    37862cc View commit details
    Browse the repository at this point in the history

  4. Hanging test fix

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    3a39a61 View commit details
    Browse the repository at this point in the history

  5. use newClient helper

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    e6eeff5 View commit details
    Browse the repository at this point in the history

  6. add callback to test

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    0a6f4be View commit details
    Browse the repository at this point in the history

  7. nullish check

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    5935a17 View commit details
    Browse the repository at this point in the history

  8. Fix done call

    @nbbeeken
    nbbeeken committed Nov 5, 2020
    Copy the full SHA
    a0d94cc View commit details
    Browse the repository at this point in the history