Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ChangeStream): use maybePromise for close, improve tests #2343

Merged
merged 29 commits into from May 6, 2020
Merged

refactor(ChangeStream): use maybePromise for close, improve tests #2343

merged 29 commits into from May 6, 2020

Commits on May 3, 2020

  1. refactor: use maybePromise for ChangeStream.close

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    7d38aa6 View commit details
    Browse the repository at this point in the history

  2. test: fix skipped mid-close tests

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    89a162f View commit details
    Browse the repository at this point in the history

  3. clean up processNewChange

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    4dd3875 View commit details
    Browse the repository at this point in the history

  4. clean up processNewChange some more

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    6a75b37 View commit details
    Browse the repository at this point in the history

  5. remove comment

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    67e9294 View commit details
    Browse the repository at this point in the history

  6. test: add waitForStarted to flaky changeStream tests

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    35a552f View commit details
    Browse the repository at this point in the history

  7. cleanup from review

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    279f3c4 View commit details
    Browse the repository at this point in the history

  8. properly fix mid-close tests

    @emadum
    emadum committed May 3, 2020
    Configuration menu
    Copy the full SHA
    182a03d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. use waitForStarted in flaky tests

    @emadum
    emadum committed May 4, 2020
    Configuration menu
    Copy the full SHA
    fd01b1c View commit details
    Browse the repository at this point in the history

  2. use waitForStarted where possible in existing tests

    @emadum
    emadum committed May 4, 2020
    Configuration menu
    Copy the full SHA
    972a6ed View commit details
    Browse the repository at this point in the history

  3. improve cleanup logic for mid-close tests

    @emadum
    emadum committed May 4, 2020
    Configuration menu
    Copy the full SHA
    b0a0fb8 View commit details
    Browse the repository at this point in the history

  4. use callback so client will close even if changeStream.close errors

    @emadum
    emadum committed May 4, 2020
    Configuration menu
    Copy the full SHA
    395a9bc View commit details
    Browse the repository at this point in the history

  5. fix typo

    @emadum
    emadum committed May 4, 2020
    Configuration menu
    Copy the full SHA
    3de4d83 View commit details
    Browse the repository at this point in the history

  6. revert changes and skip mid-close tests

    @emadum
    emadum committed May 4, 2020
    Configuration menu
    Copy the full SHA
    5e1dc83 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. test fix

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    ad22a9f View commit details
    Browse the repository at this point in the history

  2. refactor: clean up tryNext tests, add withTempDb helper

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    25609ec View commit details
    Browse the repository at this point in the history

  3. remove .only

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    891544d View commit details
    Browse the repository at this point in the history

  4. fix: dont processNewChange for closed changeStream

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    44ff554 View commit details
    Browse the repository at this point in the history

  5. fix broken mid-close tests, again

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e488d63 View commit details
    Browse the repository at this point in the history

  6. fix todo in forbidden stage test

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    e5b7802 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    c7c5bc5 View commit details
    Browse the repository at this point in the history

  8. add timeout to waitForStarted

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    b97befe View commit details
    Browse the repository at this point in the history

  9. ensure parity on mid-close events test

    @emadum
    emadum committed May 5, 2020
    Configuration menu
    Copy the full SHA
    70bdeba View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. spend less time waiting for topology

    @emadum
    emadum committed May 6, 2020
    Configuration menu
    Copy the full SHA
    8619634 View commit details
    Browse the repository at this point in the history

  2. tryNext tests should use w: majority

    @emadum
    emadum committed May 6, 2020
    Configuration menu
    Copy the full SHA
    29dedd2 View commit details
    Browse the repository at this point in the history

  3. remove old code

    @emadum
    emadum committed May 6, 2020
    Configuration menu
    Copy the full SHA
    0305e32 View commit details
    Browse the repository at this point in the history

  4. dont skip waitForTopology on unified topology

    @emadum
    emadum committed May 6, 2020
    Configuration menu
    Copy the full SHA
    4cbd81c View commit details
    Browse the repository at this point in the history

  5. lint error

    @emadum
    emadum committed May 6, 2020
    Configuration menu
    Copy the full SHA
    ffa0b38 View commit details
    Browse the repository at this point in the history

  6. clean up commented code

    @emadum
    emadum committed May 6, 2020
    Configuration menu
    Copy the full SHA
    6e8d0d6 View commit details
    Browse the repository at this point in the history