Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(changeStream): properly handle changeStream event mid-close #1902

Merged
merged 2 commits into from Jan 23, 2019
Merged

fix(changeStream): properly handle changeStream event mid-close #1902

merged 2 commits into from Jan 23, 2019

Commits on Jan 18, 2019

  1. fix(changeStream): properly handle changeStream event mid-close 

    If a changeStream gets an event while it is in the middle of closing,
a race condition can occur where the event is still processed after
the stream has closed. This commit adds handling for this edge
case by returning an error to callbacks, rejecting promises,
and simply ignoring it in emitter mode.

Fixes NODE-1831
    @daprahamian
    daprahamian committed Jan 18, 2019
    Copy the full SHA
    5cdc3bc View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. incorporating feedback

    @daprahamian
    daprahamian committed Jan 22, 2019
    Copy the full SHA
    329df24 View commit details
    Browse the repository at this point in the history