refactor: narrow ConnectionClosedEvent param type

mongodb · Sep 28, 2022 · ac95f81 · ac95f81
1 parent 0f8e6d8
commit ac95f81
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/cmap/connection_pool.ts b/src/cmap/connection_pool.ts
@@ -599,7 +599,7 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
         this[kPending]--;
         this.emit(
           ConnectionPool.CONNECTION_CLOSED,
-          new ConnectionClosedEvent(this, { id: connectOptions.id } as Connection, 'error')
+          new ConnectionClosedEvent(this, { id: connectOptions.id, serviceId: undefined }, 'error')
         );
         callback(err ?? new MongoRuntimeError('Connection creation failed without error'));
         return;

diff --git a/src/cmap/connection_pool_events.ts b/src/cmap/connection_pool_events.ts
@@ -106,7 +106,11 @@ export class ConnectionClosedEvent extends ConnectionPoolMonitoringEvent {
   serviceId?: ObjectId;
 
   /** @internal */
-  constructor(pool: ConnectionPool, connection: Connection, reason: string) {
+  constructor(
+    pool: ConnectionPool,
+    connection: Pick<Connection, 'id' | 'serviceId'>,
+    reason: string
+  ) {
     super(pool);
     this.connectionId = connection.id;
     this.reason = reason || 'unknown';