refactor: make Pool.clear take options object

mongodb · Oct 27, 2022 · 90181b1 · 90181b1
1 parent c438bcf
commit 90181b1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/cmap/connection_pool.ts b/src/cmap/connection_pool.ts
@@ -408,7 +408,8 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
    * Pool reset is handled by incrementing the pool's generation count. Any existing connection of a
    * previous generation will eventually be pruned during subsequent checkouts.
    */
-  clear(serviceId?: ObjectId): void {
+  clear(options: { serviceId?: ObjectId } = {}): void {
+    const { serviceId } = options;
     if (this.closed) {
       return;
     }

diff --git a/src/sdam/server.ts b/src/sdam/server.ts
@@ -400,14 +400,14 @@ export class Server extends TypedEventEmitter<ServerEvents> {
         error.addErrorLabel(MongoErrorLabel.ResetPool);
         markServerUnknown(this, error);
       } else if (connection) {
-        this.s.pool.clear(connection.serviceId);
+        this.s.pool.clear({ serviceId: connection.serviceId });
       }
     } else {
       if (isSDAMUnrecoverableError(error)) {
         if (shouldHandleStateChangeError(this, error)) {
           const shouldClearPool = maxWireVersion(this) <= 7 || isNodeShuttingDownError(error);
           if (this.loadBalanced && connection && shouldClearPool) {
-            this.s.pool.clear(connection.serviceId);
+            this.s.pool.clear({ serviceId: connection.serviceId });
           }
 
           if (!this.loadBalanced) {

diff --git a/src/sessions.ts b/src/sessions.ts
@@ -537,7 +537,7 @@ export function maybeClearPinnedConnection(
       );
 
       if (options?.forceClear) {
-        loadBalancer.s.pool.clear(conn.serviceId);
+        loadBalancer.s.pool.clear({ serviceId: conn.serviceId });
       }
     }