Skip to content

Commit

Permalink
test(NODE-5610): unskip uri invalid port (zero) with hostname/IP lite…
Browse files Browse the repository at this point in the history
…ral tests on Node 20+ (#4096)
  • Loading branch information
aditi-khare-mongoDB committed Apr 25, 2024
1 parent ca2bfb0 commit 6d8ad33
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions test/unit/connection_string.spec.test.ts
@@ -1,5 +1,3 @@
import { satisfies } from 'semver';

import { loadSpecTests } from '../spec';
import { executeUriValidationTest } from '../tools/uri_spec_runner';

Expand All @@ -11,22 +9,6 @@ const skipTests = [
describe('Connection String spec tests', function () {
const suites = loadSpecTests('connection-string');

beforeEach(function () {
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const test = this.currentTest!;

const skippedTests = [
'Invalid port (zero) with IP literal',
'Invalid port (zero) with hostname'
];
test.skipReason =
satisfies(process.version, '>=20.0.0') && skippedTests.includes(test.title)
? 'TODO(NODE-5666): fix failing unit tests on Node20+'
: undefined;

if (test.skipReason) this.skip();
});

for (const suite of suites) {
describe(suite.name, function () {
for (const test of suite.tests) {
Expand Down

0 comments on commit 6d8ad33

Please sign in to comment.