Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOTOR-1240 Skip GridFS tests failing due to PYTHON-4146 #261

Merged
merged 1 commit into from
Feb 20, 2024
Merged

MOTOR-1240 Skip GridFS tests failing due to PYTHON-4146 #261

merged 1 commit into from
Feb 20, 2024

Conversation

ShaneHarvey
Copy link
Member

@ShaneHarvey ShaneHarvey requested a review from a team as a code owner February 20, 2024 20:27
@ShaneHarvey
Copy link
Member Author

The remaining test failures are tracked in other issues.

Jibola
Jibola approved these changes Feb 20, 2024
View reviewed changes
synchro/synchrotest.py
@@ -131,6 +131,10 @@
"TestCursor.test_comment",
"TestCursor.test_where",
"TestGridfs.test_gridfs_find",
# Uses patching on grid_file._UPLOAD_BUFFER_SIZE which fails in synchro.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to attach a PYTHON TODO jira ticket to this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I see it as not worth the effort.

@ShaneHarvey ShaneHarvey merged commit cd6b2bb into mongodb:master Feb 20, 2024
26 of 34 checks passed
@ShaneHarvey ShaneHarvey deleted the MOTOR-1240 branch February 21, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibola Jibola Jibola approved these changes

@caseyclements caseyclements Awaiting requested review from caseyclements caseyclements was automatically assigned from mongodb/dbx-python

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ShaneHarvey @Jibola