Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOTOR-1100 Update libmongocrypt payloads to new QE protocol #205

Merged
merged 3 commits into from
May 11, 2023

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073
Copy link
Member Author

Failures are pre-existing and tracked in https://jira.mongodb.org/browse/MOTOR-1133

@@ -110,7 +110,8 @@ commands =

[testenv:py3-pymongo-latest]
commands =
pip install git+https://github.com/mongodb/mongo-python-driver.git@master#egg=pymongo[encryption]
pip install git+https://github.com/mongodb/mongo-python-driver.git@master
pip install --pre pymongocrypt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, why did you decide to use --pre even though we didn't publish a prerelease?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had mentioned in the ticket that this would allow us to publish a beta and consume it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in the future)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@blink1073 blink1073 merged commit a16d482 into mongodb:master May 11, 2023
16 of 20 checks passed
@blink1073 blink1073 deleted the MOTOR-1100 branch May 11, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants