MOTOR-969 Support for Range Indexes #195
Conversation
motor/metaprogramming.py
Outdated
| @@ -149,6 +149,8 @@ def __init__(self, attr_name, doc=None): | |||
|
|
|||
| def create_attribute(self, cls, attr_name): | |||
| name = self.attr_name or attr_name | |||
| if name == "encrypt_expression": | |||
| return | |||
There was a problem hiding this comment.
You could instead add None as the last arg to getattr() and return if it is None.
There was a problem hiding this comment.
My concern with doing it that way is that we might forget to get rid of this workaround later. In general I think we do want to raise an error in this case (for example method_that_is_mispelled = AsyncCommand()), so I want it to be as specific as possible.
There was a problem hiding this comment.
This unconditionally gets rid of the attribute though right? I think we need to first check if it exists, and then check if it is in an expected list of ones that may not exist yet.
There was a problem hiding this comment.
Ah, that is a very good point. Done.
motor/core.py
Outdated
| @@ -1979,6 +1979,7 @@ class AgnosticClientEncryption(AgnosticBase): | |||
| add_key_alt_name = AsyncCommand() | |||
| get_key_by_alt_name = AsyncCommand() | |||
| remove_key_alt_name = AsyncCommand() | |||
| encrypt_expression = AsyncCommand() | |||
There was a problem hiding this comment.
How about we remove the create_attribute changes and instead do:
if hasattr(ClientEncryption, "encrypt_expression"):
encrypt_expression = AsyncCommand()
Otherwise (with the current solution) AgnosticClientEncryption will end up with encrypt_expression = None.
There was a problem hiding this comment.
That makes sense. Done.
| kms_provider="local", | ||
| ) | ||
| with self.assertRaises(pymongo.errors.WriteError) as exc: | ||
| coll.insert_one({"ssn": "123-45-6789"}) |
There was a problem hiding this comment.
How is this working without the await? What is the type of coll here?
There was a problem hiding this comment.
This should be fixed now.
There was a problem hiding this comment.
Before there were no awaits, so the function calls were returning immediately and not raising any exceptions.
There was a problem hiding this comment.
Apparently this was failing before.
|
Can you pull from master to pick up the |
|
@blink1073 I appear to already have that commit: |
|
Hmm, then we might need to use |
|
@blink1073 I opened https://jira.mongodb.org/browse/MOTOR-1104 to track that work. |
No description provided.