Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOTOR-689: Add async wrapper for pymongo.encryption.ClientEncryption #103
MOTOR-689: Add async wrapper for pymongo.encryption.ClientEncryption #103
Changes from 34 commits
ee7b490
e252b38
8fed6c1
1ef5c2a
3e11eb7
dea8025
9a60728
75d2fdc
9a58140
a3575c0
bf05409
13f4cdb
4254aae
efddbe8
d3a73ab
0c0e70b
c6c7edd
7f9b84a
aea3442
0b2ca3b
05050b1
180509b
68bc359
b4849e0
f2615ed
bb4cbe8
310ff1c
bcff10c
29b0880
e0337ca
d569bd0
ef043bb
e093948
64f68d7
a9b976b
7011887
c4e81a3
9a03574
171becc
26cf82f
81f87cd
3f5f880
87e711f
8f6026e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add the
>=3.11,<4
here? I would hope that the version reqs are added transitively from pymongo in install_requires.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prashantmital thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think extras are applied on top of (i.e. after)
install_requiries
so we would probably need this. I'll run a quick test and get back to you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a
setup.py
that looks like:installing the package has a rather strange output log:
for some reason, it downloads all the versions between 3.10 and latest but ends up only installing the one in
install_requires
. So @ShaneHarvey does seem to be correct in thatpip
honors theinstall_requires
version. That being said, it might result in longer install times if there are a lot versions to download.Specifying the version in
extras_require
eliminates the extra downloads:@ShaneHarvey how would you like to proceed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh well. Let's keep
>=3.11,<4
. We'll just need to ensure those two reqs never drift apart.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see your concern. Let's single-source the PyMongo dependency. Maybe something like:
Thoughts @ShaneHarvey ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes let's do your single-source option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guanlinzhou can you implement this?