Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-2774 Migrate snappy testing to from Ubuntu 18 to amazon1-2018 #672

Merged
merged 1 commit into from Jul 12, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 3 additions & 18 deletions .evergreen/config.yml
Expand Up @@ -2397,28 +2397,13 @@ buildvariants:
display_name: "${c-extensions} ${python-version} ${platform} ${auth} ${ssl} ${coverage}"
tasks: *all-server-versions

- matrix_name: "tests-python-version-ubuntu18-compression"
- matrix_name: "tests-python-version-compression"
matrix_spec:
platform: [awslinux, ubuntu-18.04]
platform: [awslinux]
python-version: ["2.7", "3.4", "3.5", "3.6", "3.7", "3.8", "3.9", "pypy", "pypy3.5", "pypy3.6", "pypy3.7", "jython2.7"]
c-extensions: "*"
compression: "*"
exclude_spec:
# Only test snappy on Ubuntu-18.04 as Ubuntu 18.04 images have libsnappy-dev installed
- platform: awslinux
python-version: "*"
c-extensions: "*"
compression: ["snappy"]
# Ubuntu-18.04 does not have Python 3.4 installed
- platform: ubuntu-18.04
python-version: ["3.4"]
c-extensions: "*"
compression: ["snappy"]
# Only test zlib and zstd on Amazon Linux
- platform: ubuntu-18.04
python-version: "*"
c-extensions: "*"
compression: ["zlib", "zstd"]
# These interpreters are always tested without extensions.
- platform: "*"
python-version: ["pypy", "pypy3.5", "pypy3.6", "pypy3.7", "jython2.7"]
Expand All @@ -2443,12 +2428,12 @@ buildvariants:
rules:
# Server versions 3.6+ support snappy and zlib.
- if:
platform: "*"
python-version: "*"
c-extensions: "*"
compression: ["snappy", "zlib"]
then:
add_tasks:
- "test-5.0-standalone"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why get rid of 5.0 testing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still test against 5.0 the "test-5.0-standalone" here was redundant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it.

- "test-4.0-standalone"
- "test-3.6-standalone"

Expand Down