New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-2608 Test that KMS TLS connections verify peer certificates #667
Conversation
.evergreen/config.yml
Outdated
@@ -361,6 +361,32 @@ functions: | |||
PYTHON_BINARY=${PYTHON_BINARY} sh ${PROJECT_DIRECTORY}/.evergreen/run-doctests.sh | |||
|
|||
"run tests": | |||
# If testing encryption start the mock KMS servers. | |||
# First create the virtualenv and install dependencies. | |||
- command: shell.exec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this here, can't we do this in run-tests.sh
gated under a check on TEST_ENCRYPTION
? In config.yml under "run tests"
we seem to limit ourselves to setting up environment variables which then get used by run-tests.sh
. It'll be nice to stick to that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. That's way simpler.
This reverts commit 01d7367.
Updated to start the mock KMS servers in run-test.sh. I also moved all our scripts to bash instead of sh. The remaining windows failures are due to PYTHON-2798. |
…ongodb#667) Use bash for all evergreen scripts. (cherry picked from commit 834500d)
) Use bash for all evergreen scripts. (cherry picked from commit 834500d)
Implements the tests described here: https://github.com/mongodb/specifications/tree/master/source/client-side-encryption/tests#kms-tls-tests
Patch (Note the Windows failures are unrelated see PYTHON-2798): https://spruce.mongodb.com/version/60e643e47742ae7acd922fe3/tasks