Add top-level error labels to write concern error #766
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,205 @@ | ||
| { | ||
|
There was a problem hiding this comment. I added these two new unified tests for this, in scope of already existing DRIVERS-1385 ticket. |
||
| "description": "retryable-writes bulkWrite serverErrors", | ||
| "schemaVersion": "1.0", | ||
| "runOnRequirements": [ | ||
| { | ||
| "minServerVersion": "3.6", | ||
| "topologies": [ | ||
| "replicaset" | ||
| ] | ||
| } | ||
| ], | ||
| "createEntities": [ | ||
| { | ||
| "client": { | ||
| "id": "client0", | ||
| "useMultipleMongoses": false, | ||
| "observeEvents": [ | ||
| "commandStartedEvent" | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "database": { | ||
| "id": "database0", | ||
| "client": "client0", | ||
| "databaseName": "retryable-writes-tests" | ||
| } | ||
| }, | ||
| { | ||
| "collection": { | ||
| "id": "collection0", | ||
| "database": "database0", | ||
| "collectionName": "coll" | ||
| } | ||
| } | ||
| ], | ||
| "initialData": [ | ||
| { | ||
| "collectionName": "coll", | ||
| "databaseName": "retryable-writes-tests", | ||
| "documents": [ | ||
| { | ||
| "_id": 1, | ||
| "x": 11 | ||
| }, | ||
| { | ||
| "_id": 2, | ||
| "x": 22 | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "tests": [ | ||
| { | ||
| "description": "BulkWrite succeeds after retryable writeConcernError in first batch", | ||
| "runOnRequirements": [ | ||
| { | ||
| "minServerVersion": "4.0", | ||
| "topologies": [ | ||
| "replicaset" | ||
| ] | ||
| }, | ||
| { | ||
| "minServerVersion": "4.1.7", | ||
| "topologies": [ | ||
| "sharded-replicaset" | ||
| ] | ||
| } | ||
| ], | ||
| "operations": [ | ||
| { | ||
| "name": "failPoint", | ||
| "object": "testRunner", | ||
| "arguments": { | ||
| "client": "client0", | ||
| "failPoint": { | ||
| "configureFailPoint": "failCommand", | ||
| "mode": { | ||
| "times": 1 | ||
| }, | ||
| "data": { | ||
| "failCommands": [ | ||
| "insert" | ||
| ], | ||
| "errorLabels": [ | ||
| "RetryableWriteError" | ||
| ], | ||
| "writeConcernError": { | ||
| "code": 91, | ||
| "errmsg": "Replication is being shut down" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "name": "bulkWrite", | ||
| "object": "collection0", | ||
| "arguments": { | ||
| "requests": [ | ||
| { | ||
| "insertOne": { | ||
| "document": { | ||
| "_id": 3, | ||
| "x": 33 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "deleteOne": { | ||
| "filter": { | ||
| "_id": 2 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "expectResult": { | ||
| "deletedCount": 1, | ||
| "insertedCount": 1, | ||
| "matchedCount": 0, | ||
| "modifiedCount": 0, | ||
| "upsertedCount": 0, | ||
| "insertedIds": { | ||
| "$$unsetOrMatches": { | ||
| "0": 3 | ||
| } | ||
| }, | ||
| "upsertedIds": {} | ||
| } | ||
| } | ||
| ], | ||
| "expectEvents": [ | ||
| { | ||
| "client": "client0", | ||
| "events": [ | ||
| { | ||
| "commandStartedEvent": { | ||
| "command": { | ||
| "insert": "coll", | ||
| "documents": [ | ||
| { | ||
| "_id": 3, | ||
| "x": 33 | ||
| } | ||
| ] | ||
| }, | ||
| "commandName": "insert", | ||
| "databaseName": "retryable-writes-tests" | ||
| } | ||
| }, | ||
| { | ||
| "commandStartedEvent": { | ||
| "command": { | ||
| "insert": "coll", | ||
| "documents": [ | ||
| { | ||
| "_id": 3, | ||
| "x": 33 | ||
| } | ||
| ] | ||
| }, | ||
| "commandName": "insert", | ||
| "databaseName": "retryable-writes-tests" | ||
| } | ||
| }, | ||
| { | ||
| "commandStartedEvent": { | ||
| "command": { | ||
| "delete": "coll", | ||
| "deletes": [ | ||
| { | ||
| "q": { | ||
| "_id": 2 | ||
| }, | ||
| "limit": 1 | ||
| } | ||
| ] | ||
| }, | ||
| "commandName": "delete", | ||
| "databaseName": "retryable-writes-tests" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "outcome": [ | ||
| { | ||
| "collectionName": "coll", | ||
| "databaseName": "retryable-writes-tests", | ||
| "documents": [ | ||
| { | ||
| "_id": 1, | ||
| "x": 11 | ||
| }, | ||
| { | ||
| "_id": 3, | ||
| "x": 33 | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is more complex than it needs to be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so much better. Thanks. Added a couple of checks to a conditional protecting the loop. One is necessary for correctness, the other just to document intent.
Done.