GODRIVER-3163 Preserve original cancellation/timeout errors. #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
force-pushed
the
GODRIVER-3163-preserve-canceled-wrapper
branch
from
bcf62ef
to
7a3d47e
Compare
API Change ReportNo changes found! |
FGasper
force-pushed
the
GODRIVER-3163-preserve-canceled-wrapper
branch
from
7a3d47e
to
e7bdf99
Compare
matthewdale
changed the title
matthewdale
approved these changes
May 1, 2024
|
@matthewdale should this be ported to |
|
@blink1073 Yes, it should. Thanks for checking! |
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3163
Summary
Previously transformNetworkError() would replace original errors with either
context.Canceledorcontext.DeadlineExceeded. This changes that so that the original error information is preserved.Background & Motivation
Use of
errors.Is()implies a desire to honor wrapped errors. Replacing a wrapped error withcontext.Canceledsubverts that.This subversion adversely affects Mongosync, which wraps
context.Canceledwith detail about the cancellation’s cause. (See REP-3632 for details about this.)The same pattern applies to discarding the driver’s
originalErrorin favor of DeadlineExceeded. We can safely preserve the originalnet.Error’s context by wrapping DeadlineExceeded.