Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2982 Add PR build tags. #1387

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Conversation

qingyang-hu
Copy link
Collaborator

@qingyang-hu qingyang-hu commented Sep 14, 2023

GODRIVER-2982

Summary

Add PR build tags ("pullrequest") for easier Evergreen config.

Background & Motivation

A tag, "pullrequest", has been added to current variants as well as the "race detector" tasks so the Go driver Evergreen project can use tags instead of regexes.

Go driver Evergreen project configs will be updated later after the PR merging.

I think it would be better if we could manage the Evergreen project settings under the version control for tracking purpose. But it can be in a separate PR/ticket.

@qingyang-hu qingyang-hu marked this pull request as ready for review September 15, 2023 13:57
@qingyang-hu qingyang-hu requested a review from a team as a code owner September 15, 2023 13:57
@qingyang-hu qingyang-hu requested review from prestonvasquez, matthewdale and blink1073 and removed request for a team September 15, 2023 13:57
blink1073
blink1073 previously approved these changes Sep 15, 2023
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Member

Ah, failure:

[2023/09/15 14:22:47.708] go build go.mongodb.org/mongo-driver/x/mongo/driver/mongocrypt:
[2023/09/15 14:22:47.708] # pkg-config --cflags  -- libmongocrypt
[2023/09/15 14:22:47.708] Package libmongocrypt was not found in the pkg-config search path.
[2023/09/15 14:22:47.708] Perhaps you should add the directory containing `libmongocrypt.pc'
[2023/09/15 14:22:47.708] to the PKG_CONFIG_PATH environment variable

matthewdale
matthewdale previously approved these changes Sep 15, 2023
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

prestonvasquez
prestonvasquez previously approved these changes Sep 18, 2023
Copy link
Collaborator

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qingyang-hu qingyang-hu reopened this Sep 22, 2023
@qingyang-hu qingyang-hu merged commit 1e41b58 into mongodb:v1 Sep 22, 2023
33 of 37 checks passed
blink1073 pushed a commit to blink1073/mongo-go-driver that referenced this pull request Sep 25, 2023
qingyang-hu added a commit to qingyang-hu/mongo-go-driver that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants