GODRIVER-2792 Migrate CI to RHEL 8.7 #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
temporarily deployed
to
api-report
GitHub Actions
Inactive
API Change ReportNo changes found! |
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
temporarily deployed
to
api-report
GitHub Actions
Inactive
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
changed the title
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
requested review from
blink1073
and removed request for
a team
prestonvasquez
commented
Sep 11, 2023
| testInvalidClientEncryption bool | ||
| invalidClientEncryptionErrorSubstring string | ||
| invalidClientEncryptionErrorSubstring []string |
There was a problem hiding this comment.
The expected errors in these tests have to be updated to be a slice of possible errors. This is because DNS usage come from C linking and so DNS resolutions are OS-dependent and therefore will differ in exact verbiage: https://engineering.grab.com/dns-resolution-in-go-and-cgo
blink1073
reviewed
Sep 11, 2023
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
blink1073
reviewed
Sep 11, 2023
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
blink1073
reviewed
Sep 12, 2023
.evergreen/config.yml
Outdated
| @@ -2368,6 +2368,8 @@ axes: | |||
| GCC_PATH: "/cygdrive/c/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/bin" | |||
| GO_DIST: "C:\\golang\\go1.20" | |||
| SKIP_ECS_AUTH_TEST: true | |||
| # TODO(BUILD-17329): Update this to RHEL 8.7 after we add a new ECS task | |||
There was a problem hiding this comment.
This will actually be Ubuntu 22.
There was a problem hiding this comment.
The ticket says "We would like to add a new task definition that targets RHEL 8." I thought the goal was to move away from Ubuntu?
There was a problem hiding this comment.
The build team pushed back because it was easier to target Ubuntu on ECS.
There was a problem hiding this comment.
We're still using Ubuntu for some things in the Python toolchain, the main point of moving to RHEL was for wide support for server versions.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
qingyang-hu
pushed a commit
that referenced
this pull request
Nov 8, 2023
qingyang-hu
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2792
Summary
Migrate CI to RHEL 8.7 for long-term support.
Background & Motivation
The build team is winding down support for OSes that are either unsupported or in extended security maintenance (ESM) as part of PM-3193. This includes Ubuntu 18.04, which is in ESM in Apr 2023, and any of the RHEL 7.x build variants less than 7.6. RHEL 7.6 enters ESM in Jun 2024.