Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2174 Bump minimum Go version to 1.13. #1100

Merged
merged 7 commits into from Oct 26, 2022
Merged

GODRIVER-2174 Bump minimum Go version to 1.13. #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
accffed
GODRIVER-2174 Bump minimum Go version to 1.13 in docs.
benjirewis Oct 24, 2022
fcf0065
Update README.md
benjirewis Oct 24, 2022
6b3d5ec
bump version in go.mod
benjirewis Oct 24, 2022
f12913d
use new make target for go1.13 build
benjirewis Oct 25, 2022
27ff200
use sed instead of pcregrep
benjirewis Oct 25, 2022
94444ae
avoid using modfile flag
benjirewis Oct 25, 2022
0cc0921
try using go111module=off
benjirewis Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions .evergreen/config.yml
View file
Open in desktop
Expand Up @@ -1777,13 +1777,15 @@ tasks:
vars:
MONGO_GO_DRIVER_COMPRESSOR: "snappy"

- name: go1.10-build
- name: go1.13-build
tags: ["compile-check"]
commands:
- func: run-make
vars:
targets: "build"
BUILD_ENV: "PATH=/opt/golang/go1.10/bin:$PATH GOROOT=/opt/golang/go1.10"
# Use GO111MODULE=off to disable modules, as go versions less than
# 1.16 will complain about the retract directives in go.mod.
BUILD_ENV: "GO111MODULE=off PATH=/opt/golang/go1.13/bin:$PATH GOROOT=/opt/golang/go1.13"

# Build with whatever the latest Go version is that we're using for tests
- name: build
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -22,7 +22,8 @@ The MongoDB supported driver for Go.
-------------------------
## Requirements

- Go 1.10 or higher if using the driver as a dependency. Go 1.18 or higher if building the driver yourself. We aim to support the latest versions of Go.
- Go 1.13 or higher. We aim to support the latest versions of Go.
- Go 1.18 or higher is required to run the driver test suite.
- MongoDB 3.6 and higher.

-------------------------
Expand Down
2 changes: 1 addition & 1 deletion docs/CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ Before starting to write code, look for existing [tickets](https://jira.mongodb.
The Go Driver team uses GitHub to manage and review all code changes. Patches should generally be made against the master (default) branch and include relevant tests, if
applicable.

Code should compile and tests should pass under all Go versions which the driver currently supports. Currently the Go Driver supports a minimum version of Go 1.10 and requires Go 1.18 for development. Please run the following Make targets to validate your changes:
Code should compile and tests should pass under all Go versions which the driver currently supports. Currently the Go Driver supports a minimum version of Go 1.13 and requires Go 1.18 for development. Please run the following Make targets to validate your changes:
- `make fmt`
- `make lint` (requires [golangci-lint](https://github.com/golangci/golangci-lint) and [lll](https://github.com/walle/lll) to be installed and available in the `PATH`)
- `make test`
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
@@ -1,6 +1,6 @@
module go.mongodb.org/mongo-driver

go 1.10
go 1.13

retract (
v1.10.0 // Contains a possible data corruption bug in RewrapManyDataKey when using libmongocrypt versions less than 1.5.2.
Expand Down