Bump docfx version #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
commented
May 3, 2024
| @@ -14,7 +14,8 @@ | |||
| "disableDefaultFilter": false, | |||
| "noRestore": false, | |||
| "namespaceLayout": "flattened", | |||
| "memberLayout": "samePage", | |||
| "memberLayout": "separatePages", | |||
There was a problem hiding this comment.
Needed for easier access to specific member pages.
sanych-sun
commented
May 3, 2024
| @@ -224,6 +224,7 @@ functions: | |||
|
|
|||
| pack-packages: | |||
| - command: shell.exec | |||
| type: test | |||
There was a problem hiding this comment.
This will mark failed script as "Failed" (red) instead of "System Failure" (purple)
sanych-sun
commented
May 3, 2024
| params: | ||
| shell: bash | ||
| working_dir: mongo-efcore-provider | ||
| script: | | ||
| ${PREPARE_SHELL} | ||
| if ! [[ "$PACKAGE_VERSION" =~ ^[0-9]+\.[0-9]+\.0$ ]]; then |
There was a problem hiding this comment.
Irrelevant, as we run build-apidocs for each commit now.
sanych-sun
commented
May 3, 2024
| @@ -502,22 +513,24 @@ buildvariants: | |||
| tasks: | |||
| - name: packages-tests | |||
| git_tag_only: true | |||
| priority: 10 | |||
There was a problem hiding this comment.
Set priority for release-related tasks to prioritize package creation over regular tasks.
damieng
approved these changes
May 3, 2024
sanych-sun
force-pushed
the
bump-docfx-version
branch
from
3e8194b
to
0dbef88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped DOCFX version to support the latest language features (primary constructors first of all)
Added API docs validation script to be runned on Main and PR build for earlier problems detection.