Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSHARP-5035: Improve serverless tests to obtain secrets from vault #1314

Merged
merged 1 commit into from Apr 29, 2024

Conversation

sanych-sun
Copy link
Member

No description provided.

@sanych-sun sanych-sun requested a review from a team as a code owner April 26, 2024 18:49
@@ -738,9 +738,6 @@ functions:
- "FLE_AZURE_CLIENT_SECRET"
- "FLE_GCP_EMAIL"
- "FLE_GCP_PRIVATE_KEY"
- "SERVERLESS_ATLAS_USER"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credentials is being fetched from the vault now.

@@ -769,47 +766,6 @@ functions:
FRAMEWORK=${FRAMEWORK} \
evergreen/run-tests.sh

create-serverless-instance:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deleted create-serverless-instance and delete-serverless-instance-if-configured tasks by moving them into setup and teardown of serverless-task-group.

@@ -1059,9 +1015,6 @@ pre:
- func: make-files-executable

post:
# Removed, causing timeouts
# - func: upload-working-dir
- func: delete-serverless-instance-if-configured
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not need it here, because serverless tests have it's own task group now.

@@ -1279,7 +1232,6 @@ tasks:
- name: test-serverless
exec_timeout_secs: 2700 # 45 minutes: 15 for setup + 30 for tests
commands:
- func: create-serverless-instance
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to setup of serverless-task-group.

@@ -2387,17 +2368,12 @@ buildvariants:
- name: "test-load-balancer-netstandard21"

# Serverless tests
- matrix_name: serverless-tests-windows
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of evergreen-tools scripts were not happy with Windows host (I've got error: jq: command not found). I think it should be enough to run serverless tests on Ubuntu only. But if it's vital for us to have Windows tests as well - I can dig deeper to understand what we can do.

@sanych-sun sanych-sun requested review from BorisDog and removed request for a team April 26, 2024 20:09
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Good refactoring!
Just need to decide re. windows.

@sanych-sun sanych-sun merged commit 4f1d0dd into mongodb:master Apr 29, 2024
29 of 38 checks passed
@sanych-sun sanych-sun deleted the csharp5035 branch April 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants