Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSHARP-5067: Filters with boolean fields or properties should use correct representation of true. #1313

Merged
merged 1 commit into from
May 1, 2024
Merged

CSHARP-5067: Filters with boolean fields or properties should use correct representation of true. #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...3Implementation/Translators/ExpressionToFilterTranslators/ExpressionToFilterTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
using System.Linq.Expressions;
using MongoDB.Bson.Serialization;
using MongoDB.Driver.Linq.Linq3Implementation.Ast.Filters;
using MongoDB.Driver.Linq.Linq3Implementation.Misc;
using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToAggregationExpressionTranslators;
using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ExpressionTranslators;
using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.MethodTranslators;
Expand Down Expand Up @@ -118,7 +119,8 @@ private static AstFilter TranslateUsingQueryOperators(TranslationContext context
if (expression.Type == typeof(bool))
{
var field = ExpressionToFilterFieldTranslator.Translate(context, expression);
return AstFilter.Eq(field, true);
var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
return AstFilter.Eq(field, serializedTrue);
}

throw new ExpressionNotSupportedException(expression);
Expand Down
6 changes: 4 additions & 2 deletions ...ExpressionToFilterTranslators/ExpressionTranslators/MemberExpressionToFilterTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ public static AstFilter Translate(TranslationContext context, MemberExpression e
if (fieldInfo.FieldType == typeof(bool))
{
var field = ExpressionToFilterFieldTranslator.Translate(context, expression);
return AstFilter.Eq(field, true);
var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
return AstFilter.Eq(field, serializedTrue);
}
}

Expand All @@ -50,7 +51,8 @@ public static AstFilter Translate(TranslationContext context, MemberExpression e
if (propertyInfo.PropertyType == typeof(bool))
{
var field = ExpressionToFilterFieldTranslator.Translate(context, expression);
return AstFilter.Eq(field, true);
var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
return AstFilter.Eq(field, serializedTrue);
}
}

Expand Down
4 changes: 3 additions & 1 deletion ...ressionToFilterTranslators/ExpressionTranslators/ParameterExpressionToFilterTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

using System.Linq.Expressions;
using MongoDB.Driver.Linq.Linq3Implementation.Ast.Filters;
using MongoDB.Driver.Linq.Linq3Implementation.Misc;

namespace MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ExpressionTranslators
{
Expand All @@ -28,7 +29,8 @@ public static AstFilter Translate(TranslationContext context, ParameterExpressio
{
var serializer = context.KnownSerializersRegistry.GetSerializer(expression);
var field = AstFilter.Field(symbol.Name, serializer);
return AstFilter.Eq(field, true);
var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
return AstFilter.Eq(field, serializedTrue);
}
}

Expand Down