CSHARP-5067: Filters with boolean fields or properties should use cor…

…rect representation of true.
mongodb · Apr 26, 2024 · b15e1b6 · b15e1b6
1 parent 8af9316
commit b15e1b6
Show file tree

Hide file tree

Showing 4 changed files with 500 additions and 4 deletions.
diff --git a/...3Implementation/Translators/ExpressionToFilterTranslators/ExpressionToFilterTranslator.cs b/...3Implementation/Translators/ExpressionToFilterTranslators/ExpressionToFilterTranslator.cs
@@ -18,6 +18,7 @@
 using System.Linq.Expressions;
 using MongoDB.Bson.Serialization;
 using MongoDB.Driver.Linq.Linq3Implementation.Ast.Filters;
+using MongoDB.Driver.Linq.Linq3Implementation.Misc;
 using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToAggregationExpressionTranslators;
 using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ExpressionTranslators;
 using MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.MethodTranslators;
@@ -118,7 +119,8 @@ private static AstFilter TranslateUsingQueryOperators(TranslationContext context
             if (expression.Type == typeof(bool))
             {
                 var field = ExpressionToFilterFieldTranslator.Translate(context, expression);
-                return AstFilter.Eq(field, true);
+                var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
+                return AstFilter.Eq(field, serializedTrue);
             }
 
             throw new ExpressionNotSupportedException(expression);

diff --git a/...ExpressionToFilterTranslators/ExpressionTranslators/MemberExpressionToFilterTranslator.cs b/...ExpressionToFilterTranslators/ExpressionTranslators/MemberExpressionToFilterTranslator.cs
@@ -34,7 +34,8 @@ public static AstFilter Translate(TranslationContext context, MemberExpression e
                 if (fieldInfo.FieldType == typeof(bool))
                 {
                     var field = ExpressionToFilterFieldTranslator.Translate(context, expression);
-                    return AstFilter.Eq(field, true);
+                    var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
+                    return AstFilter.Eq(field, serializedTrue);
                 }
             }
 
@@ -50,7 +51,8 @@ public static AstFilter Translate(TranslationContext context, MemberExpression e
                 if (propertyInfo.PropertyType == typeof(bool))
                 {
                     var field = ExpressionToFilterFieldTranslator.Translate(context, expression);
-                    return AstFilter.Eq(field, true);
+                    var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
+                    return AstFilter.Eq(field, serializedTrue);
                 }
             }
 

diff --git a/...ressionToFilterTranslators/ExpressionTranslators/ParameterExpressionToFilterTranslator.cs b/...ressionToFilterTranslators/ExpressionTranslators/ParameterExpressionToFilterTranslator.cs
@@ -15,6 +15,7 @@
 
 using System.Linq.Expressions;
 using MongoDB.Driver.Linq.Linq3Implementation.Ast.Filters;
+using MongoDB.Driver.Linq.Linq3Implementation.Misc;
 
 namespace MongoDB.Driver.Linq.Linq3Implementation.Translators.ExpressionToFilterTranslators.ExpressionTranslators
 {
@@ -28,7 +29,8 @@ public static AstFilter Translate(TranslationContext context, ParameterExpressio
                 {
                     var serializer = context.KnownSerializersRegistry.GetSerializer(expression);
                     var field = AstFilter.Field(symbol.Name, serializer);
-                    return AstFilter.Eq(field, true);
+                    var serializedTrue = SerializationHelper.SerializeValue(field.Serializer, true);
+                    return AstFilter.Eq(field, serializedTrue);
                 }
             }