This repository has been archived by the owner on Oct 26, 2023. It is now read-only.
Convert Media Methods to ES5 #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use YouTube Video PublishDate for Sorting
jestapinski
requested review from
greggb,
jbouzi12 and
melissarudofsky
as code owners
|
Looking into ESM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gatsby does not support ES5 at build time and there is no clean way to get ES6 in there. We would like to use these media methods at build time as well, so as a prerequisite we must use ES5 export syntax before using these at build time.
This PR simply switches the methods we would like to use to ES5 before adding them in at build time (separate PR). I can still access the Twitch video on the home page, so everything continues to work as expected.