Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable broken require-atomic-updates rule #13

Merged
merged 1 commit into from Jun 15, 2020
Merged

Disable broken require-atomic-updates rule #13

merged 1 commit into from Jun 15, 2020

Conversation

mt-ronkorving
Copy link
Collaborator

@mt-yucheng
Copy link
Contributor

Could you add a comment describing why we're disabling this rule? (A link to pull request should be enough)

@mt-ronkorving
Copy link
Collaborator Author

mt-ronkorving commented Jun 8, 2020 •
edited

The link to the issue should provide enough context, I figured. The rule is just broken. There are way too many false positives for it to be useful.

@mt-yucheng Would you like me to put the link to the issue back in the yaml file?

@mt-ronkorving
Copy link
Collaborator Author

@mt-yucheng I've put the link back in the comment

@mt-ronkorving mt-ronkorving merged commit 4e93a3e into moneytree:master Jun 15, 2020
@mt-ronkorving mt-ronkorving deleted the disable-atomic-updates branch June 15, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt-yucheng mt-yucheng mt-yucheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mt-ronkorving @mt-yucheng