ci: Fix the method of specifying the Node.js version #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakamsha
requested review from
taigakiyokawa
and removed request for
taigakiyokawa and
tongari07
|
@taigakiyokawa |
wakamsha
requested review from
taigakiyokawa
and removed request for
taigakiyokawa
|
@taigakiyokawa @tongari07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unify the Node.js version specified for running tests in CI to the one specified in
.node-versionfile.Until now,
v14,v16andv18were specified. However, since we're currently developing according to the version described in.node-versionfile, it should be sufficient if the test succeeds with this version.Others
The format of the
CHANGELOG.mdis invalid for Prettier, but since this file is generated automatically by CD (semantic-release), it is appropriate not to have Prettier check it.