Add eslint matrix on ci (with continue-on-error) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For preparing eslint v8, add eslint matrix(v7, v8) on ci. refs #14
sanemat
force-pushed
the
chore/eslint-matrix
branch
from
4090963
to
8c23761
Compare
use continue-on-error, because we don't have allow-failure on github actions https://github.com/actions/toolkit/issues/399
sanemat
changed the title
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This is a first step for supporting eslint v8.
What
Run both eslint v7 and v8 on ci.
Ignore eslint v8 errors.
refs #14