⭐️ use cnspec for policy execution #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 21, 2022
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
9941d5d
to
edd0ba7
Compare
chris-rock
added a commit
to mondoohq/cnquery
that referenced
this pull request
Nov 21, 2022
This is required to switch our packer plugin to use cnquery / cnspec. See mondoohq/packer-plugin-cnspec#48 for more details.
chris-rock
added a commit
to mondoohq/cnspec
that referenced
this pull request
Nov 22, 2022
- allow other components to easily reuse the worst score calculation - is going to be used in mondoohq/packer-plugin-cnspec#48 once merged
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
edd0ba7
to
3282702
Compare
There was a problem hiding this comment.
@chris-rock I have tested both unregistered and registered builds on Linux and Windows. Linux works fine but Windows scans always produce the error:
mondoo-windows2019-secure-base-20221125182801.amazon-ebs.windows2019: scan packer build
==> mondoo-windows2019-secure-base-20221125182801.amazon-ebs.windows2019: scan failed: failed to resolve multiple assets
==> mondoo-windows2019-secure-base-20221125182801.amazon-ebs.windows2019: failed to resolve multiple assets
==> mondoo-windows2019-secure-base-20221125182801.amazon-ebs.windows2019: Stopping the source instance...I am happy to take a crack at the README if you are ok with me adding to this branch. Just let me know.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
ccf4c8d
to
7966b00
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
132dbc2
to
47ab464
Compare
- update to go 1.19 - remove dependency on external binary - switch to use inventory instead of option piping
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
47ab464
to
1bbcfb2
Compare
This comment has been minimized.
This comment has been minimized.
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
1bbcfb2
to
dc9ea79
Compare
tas50
reviewed
Nov 29, 2022
…o have better debug-ability Co-authored-by: Scott Ford <49754039+scottford-io@users.noreply.github.com>
Co-authored-by: Scott Ford <49754039+scottford-io@users.noreply.github.com>
chris-rock
force-pushed
the
chris-rock/cnspec
branch
from
dc9ea79
to
ce8c7fe
Compare
preslavgerchev
approved these changes
Nov 30, 2022
|
lgtm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cty dependency downgrade
Packer and Terraform use different versions of go cty. The problem is that packer does not work with the latest version of go-cty as documented here:
There are two issues, we cannot bundle both go-cty versions due to the fact that it is not labeled a major change. Out only option to get this working for now is to downgrade cty in cnquery and cnspec.
TODOs