refactor: Turn on noUnusedLocals, fix errors. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schwern
requested review from
cprice404,
malandis,
pgautier404,
poppoerika and
virratanasangpunth
cprice404
reviewed
Jan 24, 2023
|
|
||
| /** | ||
| * Creates an instance of SimpleCacheClient. | ||
| */ | ||
| constructor(props: SimpleCacheClientProps) { | ||
| initializeMomentoLogging(props.configuration.getLoggerOptions()); | ||
| this.logger = getLogger(this); |
There was a problem hiding this comment.
Instead of removing this can you just add a debug log message to the constructor or something? We will be coming back in here and adding logging at some point and I want to make sure it's really easy for devs to figure out how to do it.
There was a problem hiding this comment.
I went to do that, and there's very little to log in SimpleCacheClient. All the work is in CacheClient and ControlClient. I think this is at the wrong level.
| @@ -55,7 +55,6 @@ export abstract class SdkError extends Error { | |||
| protected readonly _errorCode: MomentoErrorCode; | |||
| protected readonly _messageWrapper: string; | |||
| private readonly _transportDetails: MomentoErrorTransportDetails; | |||
| private readonly _stack: string | undefined; | |||
There was a problem hiding this comment.
so we are never populating this anywhere?
There was a problem hiding this comment.
eslint and a search for _stack say we're not.
I know we discussed storing the stack in error messages, but we're not consistent about that.
cprice404
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the linter was configured to allow unused local properties. The check is off on nearly all our Typescript repos. There doesn't seem to be a reason not to turn the check on.
Closes #116