Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] fr-ca: Match fr for ordinals #6110

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mrleblanc101
Copy link

@mrleblanc101 mrleblanc101 commented Mar 28, 2023

We say Samedi 1er avril, but not Dimanche 2e avril.
The correct for should be Dimanche 2 avril.

This has been fixed in fr.json but not in fr-ca.json.
Fix #3375

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 28, 2023

CLA Missing ID CLA Not Signed

Copy link

@suyundukov suyundukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue got closed, so I'm not sure if there is a point in this request.

@ichernev
Copy link
Contributor

ichernev commented Dec 16, 2023

@mrleblanc101 I need some better proof about this (CLDR maybe). Also you need to change src/locale/fr.js and add tests

OK, you're copying from fr.js. I guess that is fair. But you still need to modify the src/locale/fr-ca.js and fix tests.

@ichernev ichernev changed the title Update fr-ca.js ordinal behavior to match fr.js [locale] fr-ca: Match fr for ordinals Dec 16, 2023
@mrleblanc101
Copy link
Author

@ichernev Done

@mrleblanc101
Copy link
Author

Here are some issues I found while fixing the test :(

  1. The fix in fr that this PR copy in fr-ca might not even be entirely correct !
    In french we say 1er février, and 2 février which this PR will fix.
    We only use ordinals for the first day of the month, but there is an edge-case that the current moment.js API doesn't cover.
    Sometime Do format should be 'er' or '' and something it should be 'er' or 'e'.
    Here is an exemple from the test.js file which is incorrect

The current output in fr (which would now be the behavior in fr-ca):

[
    '[le] Do [jour du mois]', 
    'le 14 jour du mois'
],

Should be in both fr and fr-ca:

[
    '[le] Do [jour du mois]', 
    'le 14e jour du mois'
],
  1. This format is not correct, the day should come before the month in french.
    But maybe it's intended so the test match between all locales ?

The current output:

[
    'dddd, MMMM Do YYYY, h:mm:ss a',
    'dimanche, février 14 2010, 3:25:50 pm',
],

What the output should be:

[
    'dddd, Do MMMM YYYY, h:mm:ss a',
    'dimanche, 14 février 2010, 3:25:50 pm',
],

@ichernev ichernev closed this Feb 18, 2024
@ichernev ichernev reopened this Feb 18, 2024
@ichernev ichernev closed this Feb 18, 2024
@ichernev ichernev reopened this Feb 18, 2024
@ichernev ichernev closed this Feb 18, 2024
@ichernev ichernev reopened this Feb 18, 2024
@ichernev ichernev closed this Feb 18, 2024
@ichernev ichernev reopened this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Canadian French ordinal
3 participants