Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct month subjective in PL #6101

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

idoodler
Copy link

If the Date format is D. MMMM the wrong Case is used.

I made the . (Dot) optional, so it will still match in both cases

If the Date format is D. MMMM the wrong Case is used.

I made the . (Dot) optional, so it will still match in both cases
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: idoodler / name: David (831d53a)

@idoodler
Copy link
Author

What is blocking here?

@idoodler
Copy link
Author

Thanks for approving, I am doing such a structured merge request the first time. Do I need to do smth, or can I just wait?

@idoodler
Copy link
Author

@anandfresh What is missing here?

@ichernev
Copy link
Contributor

@idoodler @anandfresh @iconio what all of you is missing is that the auto-generated files should not be touched. The source is in src/ (like src/locale/pl.js). Also you need to add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants