Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new locale] or: Orida #6066

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

avireni
Copy link

@avireni avireni commented Nov 11, 2022

moment.js does not support Odia (Oriya) - or locale.
Closes 6050

Additional context: Odia (Oriya) is spoken by nearly 50,000,000 people in the world.
Used Resources: https://scriptsource.org/cms/scripts/page.php?item_id=entry_detail&uid=e78ee6ssnm

Unit Tests:

moment_tests

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 11, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@avireni avireni force-pushed the feat/locale_or branch 2 times, most recently from 0099844 to eb21135 Compare November 12, 2022 03:22
@jarias-lfx
Copy link

/easycla

@avireni avireni force-pushed the feat/locale_or branch 2 times, most recently from 862cac5 to 817414b Compare November 15, 2022 18:33
@Kristin-at-Fountain
Copy link

Kristin-at-Fountain commented Dec 28, 2022

When can we expect this PR to get merged? We are looking to add this language to our product as well !

cc @avireni

@avireni
Copy link
Author

avireni commented Jan 16, 2023

Hi Reviewing Team, Can this PR be reviewed and merged if it looks good.
Added support for OR locale and addressing requests for this locale's support.

Copy link

@rakesh-fountain rakesh-fountain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few suggestions as per Odia script as Odia is my mother tongue, otherwise looks good!

src/locale/or.js Outdated Show resolved Hide resolved
src/locale/or.js Outdated Show resolved Hide resolved
src/locale/or.js Outdated Show resolved Hide resolved
@vpradhan-fountain
Copy link

Is there anything blocking this PR from being merged?

@Kristin-at-Fountain
Copy link

@anandfresh Can we please get this merged?

avireni and others added 3 commits June 2, 2023 14:16
Co-authored-by: Rakesh Patra <121806526+rakesh-fountain@users.noreply.github.com>
Co-authored-by: Rakesh Patra <121806526+rakesh-fountain@users.noreply.github.com>
Co-authored-by: Rakesh Patra <121806526+rakesh-fountain@users.noreply.github.com>
@avireni
Copy link
Author

avireni commented Jun 2, 2023

@anandfresh Can we merge this PR. Its been pending for very long and @Kristin-at-Fountain wants to use this change.

@avireni
Copy link
Author

avireni commented Oct 20, 2023

Can this PR be merged? Pending since almost a year now

@ichernev ichernev changed the title [new locale] added new locale: or odiya indian language [new locale] or: Orida Dec 16, 2023
@ichernev
Copy link
Contributor

When I rebase and run the tests there are a bunch of issues. @avireni can you check.

@Kristin-at-Fountain @vpradhan-fountain moments is in maintenance mode. In good times I released once is 3 months. Now if you get it once per year you should be happy. In any case, adding a locale for your app/website is trivial -- just copy the code and load it after moment (you can even wrap a local moment import that imports the real moment and all external locales you like). This way you won't have to wait for random people on the internet to do something that they may or may not do (ever).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing locale for Oriya (Odia) language from India
7 participants