Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[locale] vi: Improve months, weekdays and relative week #5912

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[locale] vi: Improve months, weekdays and relative week #5912

wants to merge 1 commit into from

Conversation

nobiit
Copy link

@nobiit nobiit commented Jul 15, 2021

Oh. I think this is a fix that many people will like.

Note: Case style based on en-gb locale

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 88.525% when pulling c1b2646 on NobiDev:develop into e968092 on moment:develop.

@ichernev
Copy link
Contributor

According to CLDR format/stand-alone formats use lower/uppercase. https://github.com/unicode-org/cldr/blob/main/common/main/vi.xml#L2649

To fix it properly, you can add standalone/format variants. Check src/locale/ru.js for inspiration.

@ichernev ichernev changed the title Fix case style for the Vietnamese language [locale] vi: Improve month names Dec 24, 2023
@ichernev ichernev changed the title [locale] vi: Improve month names [locale] vi: Improve months, weekdays and relative week Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nobiit @coveralls @ichernev @anandfresh