Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] More complete type definitions for strict formatless parsing #4611 #5574

Merged
merged 2 commits into from Sep 15, 2020
Merged

[bugfix] More complete type definitions for strict formatless parsing #4611 #5574

merged 2 commits into from Sep 15, 2020

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented May 31, 2020 •
edited

see #4611

@thorn0 thorn0 changed the title Reflect changes from #4611 in ts3.1-typings [bugfix] Reflect changes from #4611 in ts3.1-typings May 31, 2020
@coveralls
Copy link

coveralls commented May 31, 2020 •
edited

Coverage Status

Coverage decreased (-0.07%) to 88.432% when pulling d83f385 on thorn0:strict-parse-ts31 into e3c6790 on moment:develop.

@thorn0 thorn0 changed the title [bugfix] Reflect changes from #4611 in ts3.1-typings [bugfix] More complete type definitions for changes from #4611 May 31, 2020
@marwahaha
Copy link
Member

@Alanscut what do you think?

@marwahaha marwahaha changed the title [bugfix] More complete type definitions for changes from #4611 [bugfix] More complete type definitions for strict formatless parsing #4611 Sep 15, 2020
@marwahaha marwahaha merged commit a364b34 into moment:develop Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Help Wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thorn0 @coveralls @marwahaha