[bugfix] Fix humanize api #5477
Merged
+21
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Humanize API was changed in PR 4296 to support an options argument which contained both suffix and thresholds. No other moment API contains such an options object. So this change just splits suffix and thresholds into two different arguments, allowing for arbitrary order.
nlevman
reviewed
May 1, 2020
| @@ -79,33 +79,27 @@ export function getSetRelativeTimeThreshold(threshold, limit) { | |||
| return true; | |||
There was a problem hiding this comment.
After your changes I got "export 'duration' (imported as 'moment') was not found in 'moment'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Humanize API was changed in PR 4296 to support an options argument which
contained both suffix and thresholds. No other moment API contains such
an options object. So this change just splits suffix and thresholds into
two different arguments, allowing for arbitrary order.