Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] ja: Add new 'Reiwa' Era #5471

Merged

Conversation

eternalharvest
Copy link
Contributor

@caged ichernev

Thank u for merging my PR.
But, since my original PR was written bit long ago, In Japan the era has changed to new 'Reiwa' Era.
So, I need to add new Era definitions for Japanese locale.
This patch fix this issue, and rewrite test cases for this.

I would appreciate if this patch will be merged until next release.
Best, Regards.

Reference (Original PR)

#4599 [feature] Add era support for en,ja

@coveralls
Copy link

coveralls commented Apr 28, 2020

Coverage Status

Coverage increased (+0.0004%) to 88.471% when pulling eb4c395 on eternalharvest:feature/add_new_japanese_reiwa_era into 1021c01 on moment:develop.

@eternalharvest
Copy link
Contributor Author

sorry, this patch contains some issue related to coding style.
i'll fix this as soon as possible.

@eternalharvest
Copy link
Contributor Author

I fixed the issue related to the coding style.
Now, It's ready to merge!

@ichernev
Copy link
Contributor

@eternalharvest the most recent 2 eras lack since/until (they only have since), is that on purpose?

@ichernev ichernev merged commit 709579a into moment:develop Apr 29, 2020
@eternalharvest
Copy link
Contributor Author

@ichernev

Sorry for my late reply.
The reason why the most recent 2 eras lacking until definitions is just totally slipped my mind.
But the result it self is same even if the until definition is set.
Because when the until definition is not defined, the day until is considered as +Infinity and when the period of Eras is overlapped the most recent era is choosed.

@eternalharvest eternalharvest deleted the feature/add_new_japanese_reiwa_era branch May 1, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants