Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Make Duration#as work with quarters #4887

Merged
merged 1 commit into from Jan 18, 2019
Merged

[bugfix] Make Duration#as work with quarters #4887

merged 1 commit into from Jan 18, 2019

Conversation

alfaslash
Copy link
Contributor

fixes #4886

Example:

moment.duration(6, 'M').as('Q');      // 2
moment.suration(9, 'M').asQuarter();  // 3

@jsf-clabot
Copy link

jsf-clabot commented Dec 5, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

@alfaslash alfaslash changed the title Make Duration#as work with quarters [bugfix] Make Duration#as work with quarters Dec 5, 2018
@ichernev
Copy link
Contributor

@alfaslash thank you, looks good!

@ichernev ichernev mentioned this pull request Jan 10, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 88.145% when pulling 7535815 on alfaslash:develop into c68b4f1 on moment:develop.

@marwahaha marwahaha merged commit 4d5db33 into moment:develop Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function as does not support quarter parameter
5 participants
@alfaslash @jsf-clabot @ichernev @coveralls @marwahaha