Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small changes in locale pt-Br translation #4841

Closed
wants to merge 1 commit into from
Closed

small changes in locale pt-Br translation #4841

wants to merge 1 commit into from

Conversation

Italo-J-A-Fernandes
Copy link

Small changes but that leaves Moment.js much more pleasant and consistent with the one used in that country

@jsf-clabot
Copy link

jsf-clabot commented Nov 1, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Italo José Araujo Fernandes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 88.164% when pulling fde4285 on Italo-J-A-Fernandes:develop into c68b4f1 on moment:develop.

@coveralls
Copy link

coveralls commented Nov 1, 2018

Coverage Status

Coverage decreased (-0.02%) to 88.117% when pulling fde4285 on Italo-J-A-Fernandes:develop into c68b4f1 on moment:develop.

@Italo-J-A-Fernandes
Copy link
Author

I apologize for the failure but now the Contributor License Agreement is signed

@marwahaha
Copy link
Member

@Italo-J-A-Fernandes please edit src/locale/pt-br.js. There have been other discussions about this locale file. I recommend you search the Github issues in this repository for other discussions.

@caio-ribeiro-pereira approval ?

@caio-ribeiro-pereira
Copy link
Contributor

@Italo-J-A-Fernandes @marwahaha everything is fine, except that I do not agree with the line:

weekdaysMin : 'Do_Se_Te_Qa_Qi_Se_Sá'.split('_')

maybe it should be better in the previous way:

weekdaysMin : 'Do_2ª_3ª_4ª_5ª_6ª_Sá'.split('_'),

@caio-ribeiro-pereira
Copy link
Contributor

another question why change from lowercase to capitalize? I think for a lib this kind of information should not be formmated, because I lot of system are using in this way.

What do you think guys?

@marwahaha
Copy link
Member

For now, we will not take this change.
Please re-open if you come to an agreement on the proper locale file.
I have merged the other change from #4557 and #4558 .

@marwahaha marwahaha closed this Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants