Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endOf day on brazilian DST start being the next day #4804

Closed
wants to merge 1 commit into from

Conversation

gfpacheco
Copy link

I discovered that the order of the computation of the end of day is resulting in:

moment('2018-11-04T09:00:00-02:00').endOf('day').toString();
// Mon Nov 05 2018 00:59:59 GMT-0200

And this simple change in the order of the operations results in:

moment('2018-11-04T09:00:00-02:00').endOf('day').toString();
// Sun Nov 04 2018 23:59:59 GMT-0200

Is this a good enough solution?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 94.691% when pulling 33b0106 on gfpacheco:fix-dst-endof into 2e2a5b3 on moment:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 94.691% when pulling 33b0106 on gfpacheco:fix-dst-endof into 2e2a5b3 on moment:develop.

@gfpacheco
Copy link
Author

One month and not a single comment

@marwahaha
Copy link
Member

marwahaha commented Jan 18, 2019

I think this is obsolete by #4338. Please reopen if not.

@marwahaha marwahaha closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants