[locale] Extend cs locale with name of the months in genitive #4765
Conversation
In Czech, it is possible to use also declined form of the month name instead of nominative case. This commit adds those declined names of the months.
|
|
|
travis failed on locale/ka.js - which were untouched by this PR |
There was a problem hiding this comment.
From the Czech language perspective the change is fine. There are some code changes needed though. @marxsk can you please check my version at saxicek@3319adb - maybe it would be easier for others to understand than the version by Petr Bela. If you agree I can create PR for that.
| equalTest(tests[i][0].toLocaleUpperCase(), 'MMMM', i); | ||
| equalTest(tests[i][1].toLocaleUpperCase(), 'MMMM', i); | ||
| equalTest(tests[i][2].toLocaleUpperCase(), 'MMMM', i); | ||
|
|
||
| equalTestStrict(tests[i][1], 'MMM', i); | ||
| equalTestStrict(tests[i][0], 'MMMM', i); |
There was a problem hiding this comment.
I think you are missing tests here for equalTestStrict(tests[i][2], 'MMMM', i);
| @@ -71,12 +72,13 @@ function translate(number, withoutSuffix, key, isFuture) { | |||
|
|
|||
| export default moment.defineLocale('cs', { | |||
| months : months, | |||
| monthsGenitive: monthsGenitive, | |||
| monthsShort : monthsShort, | |||
| monthsParse : (function (months, monthsShort) { | |||
There was a problem hiding this comment.
monthsGenitive should be passed as a parameter here to be able to override?
| @@ -90,7 +92,7 @@ export default moment.defineLocale('cs', { | |||
| longMonthsParse : (function (months) { | |||
There was a problem hiding this comment.
monthsGenitive should be passed as a parameter here to be able to override?
|
@saxicek - I'm fine with yours version. |
|
Created #4771 so I believe this PR can be closed now. |
In Czech, it is possible to use also declined form of the month name instead of the nominative case.
This commit adds those declined names of the months.
@radekdostal @saxicek - please verify this patch as locales have to be verified by native speakers.