[bugfix] Fix warnings flagged by closure compiler #4350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
davido
force-pushed
the
unnecessary_escape_closure_compiler_warnings
branch
from
621fffd
to
ff411bc
Compare
marwahaha
changed the title
|
I expect this was a bug and we actually intended the RegExp to search for a literal period. In that case, the correct fix should be to double the backslashes rather than removing them. |
This statement as it stands:
this.weekdays(mom, '').replace('.', '\.?')
is not correct, and recent closure compiler issues unnecessary escape
warning, claiming that '\.' is equivalent to just '.'.
It was actually intended the RegExp to search for a literal period. In
that case the correct fix would be to double the backslashes rather than
removing them.
davido
force-pushed
the
unnecessary_escape_closure_compiler_warnings
branch
from
ff411bc
to
8aa0be6
Compare
Done. |
|
Can we add a couple tests around this? If the tests pass both ways, then it's not clear what the intended behavior is. |
openstack-gerrit
pushed a commit
to openstack-infra/gerrit
that referenced
this pull request
Jan 18, 2018
The latest rules_closure changes updated closure compiler version and remove stale bazel version check, that broke Bazel CI for gerrit: [1]. It turns out that the current code cannot be compiled by the latest closure compiler, so that it must be adjusted first. We add two more suppressions to the closure compiler invocation: * JSC_UNNECESSARY_ESCAPE * JSC_JSDOC_MISSING_TYPE_WARNING Some of the warnings flagged by the closure compiler are related to the moment library. The PR to fix them is pending for review: [2]. * [1] bazelbuild/bazel#4425 * [2] moment/moment#4350 Change-Id: I0354ceddc7f615d93b5d23cf2652b8552e53cc91
openstack-gerrit
pushed a commit
to openstack-infra/gerrit
that referenced
this pull request
Feb 5, 2018
The latest rules_closure changes updated closure compiler version and remove stale bazel version check, that broke Bazel CI for gerrit: [1]. It turns out that the current code cannot be compiled by the latest closure compiler, so that it must be adjusted first. We add two more suppressions to the closure compiler invocation: * JSC_UNNECESSARY_ESCAPE * JSC_JSDOC_MISSING_TYPE_WARNING Some of the warnings flagged by the closure compiler are related to the moment library. The PR to fix them is pending for review: [2]. * [1] bazelbuild/bazel#4425 * [2] moment/moment#4350 Change-Id: I0354ceddc7f615d93b5d23cf2652b8552e53cc91
|
closing in favor of #4453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4347.